[GitHub] [beam] robinyqiu edited a comment on pull request #11957: [BEAM-10033] zetaSqlValueToJavaObject uses value.getType()

Mon, 15 Jun 2020 11:59:39 -0700 


robinyqiu edited a comment on pull request #11957:
URL: https://github.com/apache/beam/pull/11957#issuecomment-644318238


   Because of the problems mentioned above, I did not change the implementation 
of `zetaSqlTypeToBeamFieldType`, instead I added another overload of it which 
does not depend on Beam `fieldType`. It will allow compliance test driver to 
call it (cl/316152825).
   
   @apilloud Please check if this PR still LGTY.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to