robertwb commented on code in PR #21803: URL: https://github.com/apache/beam/pull/21803#discussion_r894905446
########## sdks/python/apache_beam/ml/inference/sklearn_inference.py: ########## @@ -43,13 +41,26 @@ class ModelFileType(enum.Enum): JOBLIB = 2 -class SklearnModelHandler(ModelHandler[Union[numpy.ndarray, pandas.DataFrame], - PredictionResult, - BaseEstimator]): - """ Implementation of the ModelHandler interface for scikit-learn. +def load_model(model_uri, file_type): Review Comment: I was thinking a new abstract SkLearn base class, but that's probably not worth its weight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
