yeandy commented on code in PR #21806:
URL: https://github.com/apache/beam/pull/21806#discussion_r895618929
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -104,9 +110,9 @@ def __init__(
self,
model_handler: ModelHandler[ExampleT, PredictionT, Any],
clock=time,
- **kwargs):
+ extra_runinference_args: Optional[Dict[str, Any]] = None):
Review Comment:
Changed, and added.
##########
sdks/python/apache_beam/ml/inference/pytorch_inference_test.py:
##########
@@ -115,12 +115,12 @@ def forward(self, x):
return out
-class PytorchLinearRegressionKwargsPredictionParams(torch.nn.Module):
+class PytorchLinearRegressionKeyedBatchAndExtraParams(torch.nn.Module):
"""
- A linear model with kwargs inputs and non-batchable input params.
+ A linear model with batched keyed inputs and non-batchable extra params.
- Note: k1 and k2 are batchable inputs passed in as a kwargs.
- prediction_param_array, prediction_param_bool are non-batchable inputs
+ Note: k1 and k2 are batchable examples passed in as a keyed to torch dict.
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
