chamikaramj commented on code in PR #21852:
URL: https://github.com/apache/beam/pull/21852#discussion_r897311595
##########
sdks/java/expansion-service/build.gradle:
##########
@@ -40,6 +40,7 @@ dependencies {
implementation project(path: ":sdks:java:core", configuration: "shadow")
implementation project(path: ":runners:core-construction-java")
implementation project(path: ":runners:java-fn-execution")
+ implementation project(path:
":sdks:java:extensions:google-cloud-platform-core")
Review Comment:
Is see, in that case think we would need more refactoring to do this without
unnecessarily bloating all expansion service jars.
For example, we could consider introducing a method to "ExpansionService"
called "configureExpansionServiceProperties" (a no-op by default) and implement
that in a "ExpansionService" sub-class available in
"google-cloud-platform/expansion-service/"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
