boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r442951203
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -681,11 +696,13 @@ public void setValueDeserializer(String
valueDeserializer) {
}
/**
- * Sets {@link TimestampPolicy} to {@link
TimestampPolicyFactory.LogAppendTimePolicy}. The
- * policy assigns Kafka's log append time (server side ingestion time) to
each record. The
- * watermark for each Kafka partition is the timestamp of the last record
read. If a partition
- * is idle, the watermark advances to couple of seconds behind wall time.
Every record consumed
- * from Kafka is expected to have its timestamp type set to
'LOG_APPEND_TIME'.
+ * Sets {@link TimestampPolicy} to {@link
TimestampPolicyFactory.LogAppendTimePolicy} which is
+ * used when beam_fn_api is disabled, and sets {@code
extractOutputTimestampFn} as {@link
+ * ReadViaSDF.ExtractOutputTimestampFns#withLogAppendTime()}, which is
used when beam_fn_api is
+ * enabled. The policy assigns Kafka's log append time (server side
ingestion time) to each
+ * record. The watermark for each Kafka partition is the timestamp of the
last record read. If a
+ * partition is idle, the watermark advances to couple of seconds behind
wall time. Every record
+ * consumed from Kafka is expected to have its timestamp type set to
'LOG_APPEND_TIME'.
Review comment:
The ` which is used when beam_fn_api is disabled` means
`TimestampPolicy` is used when beam_fn_api is disabled. I'll say it explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
