ryanthompson591 commented on code in PR #22282:
URL: https://github.com/apache/beam/pull/22282#discussion_r922466174
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -384,6 +401,7 @@ def setup(self):
self._model = self._load_model()
def process(self, batch, inference_args):
+ self._model_handler.validate_inference_args(inference_args)
Review Comment:
Oh, yeah, I like the idea of putting it into expand. I think that should
catch an error even earlier.
I was thinking about it being a side input. Correct me if I'm wrong, but
even a changing side input should still be caught in this case right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
