steveniemitz commented on code in PR #22289:
URL: https://github.com/apache/beam/pull/22289#discussion_r928061849
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/RowWriterFactory.java:
##########
@@ -135,10 +136,12 @@ BigQueryRowWriter<ElementT> createRowWriter(String
tempFilePrefix, DestinationT
throw new IllegalStateException(
"createRowWriter called when schemaFactory is null; forgot to call
prepare()?");
}
+ @SuppressWarnings({
Review Comment:
given that `schemaFactory` here is a `SerializableFunction`, I don't think
that's really feasible. Doing so (changing SerializableFunction.apply to take
a nullable input) would cause a large amount of checker failures elsewhere, and
changing the interface would be a breaking API change.
Did you have something else in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
