pabloem commented on code in PR #17159:
URL: https://github.com/apache/beam/pull/17159#discussion_r930748919
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2422,6 +2422,9 @@ class ReadFromBigQuery(PTransform):
to run queries with INTERACTIVE priority. This option is ignored when
reading from a table rather than a query. To learn more about query
priority, see: https://cloud.google.com/bigquery/docs/running-queries
+ output_type (str): By default, the schema returned from this transform
+ would be of type PYTHON_DICT. Other schema types can be specified
+ ("BEAM_ROW").
Review Comment:
we don't need to have schema inference for this, though, right? We just need
to ensure the output values look like dicts to consumer transforms, look like
namedtuples to the pcollection coder, and the schema coder should be set for
the pcollection - is that it? may not need to wait for #22086?
However, like I said, I don't really know all of the implications of
actually implementing those things - so if it's too much trouble, I'm okay with
moving forward as-is. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
