aaltay commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-648280381


   > > @TobKed - please ping me if this is ready to be merged.
   > 
   > @aaltay I think it is ready, however I have some questions before it can 
me merged:
   > 
   > 1. Who can can and should setup secrets for GitHub Repository? I described 
necessary secret variables in PR description (**Before merging**) 
([docs](https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets))
   
   I do not have access to the "Settings" tab. Could you work with @tysonjh and 
infra on this one?
   
   > 2. Who can can and should setup versioning and lifecycle management for 
GCS Bucket?
   
   I can give you access to apache-beam-testing project to update things. Or I 
can do it. Let me know.
   
   > 3. What do you think about not storing `GCP_BUCKET` as the secret but 
hardcoding it, as it is in `beam-wheels` repository?
   >    Staging bucket is publicly available and not using secret will allow to 
show full path to the files in the github actions logs.
   >    It will make easier to update/modify sh scripts for release process as 
well.
   >    I propose to use `beam-wheels-staging` bucket as it is in `beam-wheels`.
   
   Sounds good to me.
   
   > 
   > WDYT?
   
   @tysonjh could help.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to