dpcollins-google commented on code in PR #22612: URL: https://github.com/apache/beam/pull/22612#discussion_r941379594
########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/ApiServices.java: ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.pubsublite.internal; + +import com.google.api.core.ApiService; +import java.util.concurrent.TimeUnit; + +class ApiServices { + + private ApiServices() {} + + static AutoCloseable asCloseable(ApiService service) { + return () -> service.stopAsync().awaitTerminated(1, TimeUnit.MINUTES); Review Comment: An exception is thrown if this times out- 1 minute is far, far longer than it should be waiting for, this is made to work around potential GRPC or client library bugs that cause this to block forever. 1 minute doesnt really need to be adjustable. ########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/BlockingCommitterImpl.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.pubsublite.internal; + +import static com.google.cloud.pubsublite.internal.ExtractStatus.toCanonical; + +import com.google.cloud.pubsublite.Offset; +import com.google.cloud.pubsublite.internal.wire.Committer; +import java.util.concurrent.TimeUnit; + +public class BlockingCommitterImpl implements BlockingCommitter { + + private final Committer committer; + + BlockingCommitterImpl(Committer committer) { + if (!committer.isRunning()) { + throw new RuntimeException(committer.failureCause()); + } + this.committer = committer; + } + + @Override + public void commitOffset(Offset offset) { + try { + committer.commitOffset(offset).get(1, TimeUnit.MINUTES); Review Comment: See above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
