lukecwik commented on pull request #12062:
URL: https://github.com/apache/beam/pull/12062#issuecomment-648975358


   > > IIUC, this changes all state handlers to use same cache token value, but 
doesn't reduce the number of user state cache token in process bundle request 
to 1?
   > 
   > Yes, it reduces the number of user state cache tokens for process bundle 
requests per process bundle descriptor to 1.
   
   I think the logic in 
`ByteStringStateRequestHandlerToBagUserStateHandlerFactoryAdapter#getCacheTokens`
 
https://github.com/apache/beam/blob/f98104a22b69972744a13378e17af5f2361fbb3e/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/state/StateRequestHandlers.java#L590
 is going to add N copies of the same cache token to the `ProcessBundleRequest`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to