dpcollins-google commented on code in PR #22612:
URL: https://github.com/apache/beam/pull/22612#discussion_r942377949
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/CheckpointMarkImpl.java:
##########
@@ -62,7 +66,11 @@ public CheckpointMarkImpl decode(InputStream inStream)
throws IOException {
@Override
public void finalizeCheckpoint() {
- checkState(committer.isPresent());
- committer.get().commitOffset(offset);
+ try {
+ checkState(committer.isPresent());
Review Comment:
The implementation does not rely on this. It only affects stackdriver
metrics and resumption after drain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
