amaliujia commented on a change in pull request #12079:
URL: https://github.com/apache/beam/pull/12079#discussion_r445163189
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##########
@@ -383,4 +392,30 @@ public Long extractOutput(Long accum) {
return accum;
}
}
+
+ static class BitAnd<T extends Number> extends CombineFn<T, Long, Long> {
+ @Override
+ public Long createAccumulator() {
+ return -1L;
Review comment:
That's a good point 👍 I should go back to re-visit CMU 15231 course
slides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
