lostluck commented on code in PR #22618:
URL: https://github.com/apache/beam/pull/22618#discussion_r943966098
##########
sdks/python/container/boot.go:
##########
@@ -211,7 +211,7 @@ func main() {
for _, workerId := range workerIds {
go func(workerId string) {
log.Printf("Executing: python %v", strings.Join(args, "
"))
- log.Fatalf("Python exited: %v",
execx.ExecuteEnv(map[string]string{"WORKER_ID": workerId}, "python", args...))
+ log.Printf("Python exited: %v",
execx.ExecuteEnv(map[string]string{"WORKER_ID": workerId}, "python", args...))
wg.Done()
Review Comment:
I'll note that the wait group state won't matter because log.Fatal will kill
the binary anyway.
Sibling worker processes (as python uses) need everything to be torn down
when one of them dies and exits out. This keeps cleaner parity with the other
SDK languages, and matches execution model assumptions. (an SDK worker dying
means there's a problem with the VM generally, and it's better for the runner
to start the whole thing fresh).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
