lukecwik commented on code in PR #22645:
URL: https://github.com/apache/beam/pull/22645#discussion_r948486244
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java:
##########
@@ -968,6 +970,10 @@ public void processElement(ProcessContext c, BoundedWindow
window) throws Except
new FileResult<>(writer.getOutputFile(), shard, window,
c.pane(), entry.getKey())));
closeWriterInBackground(writer);
}
+
+ // Ensure that the past closes happen before returning and after we
started the closes
Review Comment:
Done, thanks for making this clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
