ZijieSong946 commented on a change in pull request #12054:
URL: https://github.com/apache/beam/pull/12054#discussion_r445627742
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java
##########
@@ -375,38 +376,6 @@ public void testNullInnerRow() {
pipeline.run().waitUntilFinish(Duration.standardMinutes(2));
}
- private static class DummySqlTimeType implements Schema.LogicalType<Long,
Instant> {
- @Override
- public String getIdentifier() {
- return "SqlTimeType";
- }
-
- @Override
- public FieldType getArgumentType() {
- return FieldType.STRING;
- }
-
- @Override
- public String getArgument() {
- return "";
- }
-
- @Override
- public Schema.FieldType getBaseType() {
- return Schema.FieldType.DATETIME;
- }
-
- @Override
- public Instant toBaseType(Long input) {
- return (input == null ? null : new Instant((long) input));
- }
-
- @Override
- public Long toInputType(Instant base) {
- return (base == null ? null : base.getMillis());
- }
- }
-
@Test
public void testNullDatetimeFields() {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
