alexeyinkin commented on code in PR #22794:
URL: https://github.com/apache/beam/pull/22794#discussion_r960502458
##########
learning/tour-of-beam/frontend/lib/pages/welcome/screen.dart:
##########
@@ -31,45 +31,30 @@ import '../../constants/sizes.dart';
class WelcomeScreen extends StatelessWidget {
const WelcomeScreen();
- static const horizontalHalves = [
- TableRow(
- children: [
- TableCell(
- verticalAlignment: TableCellVerticalAlignment.fill,
- child: _SdkSelection(),
- ),
- _TourSummary(),
- ],
- ),
- ];
-
- static const verticalHalves = [
- TableRow(
- children: [
- TableCell(
- child: _SdkSelection(),
- ),
- ],
- ),
- TableRow(
- children: [
- _TourSummary(),
- ],
- ),
- ];
-
@override
Widget build(BuildContext context) {
return PageContainer(
child: SingleChildScrollView(
- child: Table(
- border: TableBorder.symmetric(
- inside: BorderSide(color: ThemeColors.of(context).divider),
- ),
- children: MediaQuery.of(context).size.width > ScreenSizes.medium
- ? horizontalHalves
- : verticalHalves,
- ),
+ child: MediaQuery.of(context).size.width > ScreenSizes.medium
Review Comment:
Done with the above naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
