ZijieSong946 commented on a change in pull request #12054:
URL: https://github.com/apache/beam/pull/12054#discussion_r445974593
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java
##########
@@ -452,21 +412,32 @@ public void testNullDatetimeFields() {
.addNullableField("year_with_null", FieldType.INT64)
.addField("mm", FieldType.INT64)
.addNullableField("month_with_null", FieldType.INT64)
- .addField("time_with_hour_added", FieldType.DATETIME)
Review comment:
Yeah. But it seems nothing wrong with these test cases. I think we could
just leave it here right now and update them when we implementing TIMESTAMP
type translation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
