mosche commented on code in PR #23041:
URL: https://github.com/apache/beam/pull/23041#discussion_r965101320
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1411,8 +1413,13 @@ class BeamModulePlugin implements Plugin<Project> {
project.tasks.register("jmh", JavaExec) {
dependsOn project.classes
- mainClass = "org.openjdk.jmh.Main"
+ mainClass = "org.apache.beam.sdk.testutils.jmh.Main"
classpath = project.sourceSets.main.runtimeClasspath
+
+ environment([
+ 'INFLUXDB_MEASUREMENT': 'java_jmh_' + (getPath().split(':') - ['',
'sdks', 'java', 'jmh']).join('_')
Review Comment:
Ok, that sounds perfectly reasonable to me. Thanks for the suggestion 👍
I'll turn this into a prefix and append the label of the JMH mode, so this
would basically end up being `java_jmh_thrpt`. I was briefly considering if
the measurement name should also include the `scoreUnit` (in case changed using
`-tu`), but I don't think so. Regardless of the scale, semantically it's still
the same type of measurement. But let me know if you disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
