dxichen commented on code in PR #22976:
URL: https://github.com/apache/beam/pull/22976#discussion_r966279006
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaTimerInternalsFactory.java:
##########
@@ -191,11 +193,26 @@ public Collection<KeyedTimerData<K>> removeReadyTimers() {
state.reloadEventTimeTimers();
}
}
+
+ // Flush all timers for process time
+ final Iterator<KeyedTimerData<K>> processBufferIterator =
processTimeBuffer.iterator();
+ while (processBufferIterator.hasNext() && readyTimers.size() <
maxReadyTimersToProcessOnce) {
+ KeyedTimerData<K> processTimerData = processBufferIterator.next();
+ readyTimers.add(processTimerData);
+ processBufferIterator.remove();
+ state.deletePersisted(processTimerData);
Review Comment:
due to samza checkpointing with changelog/blobstore, and state on restart
from failure is read from the checkpoint any persisted deletes will be rolled
back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
