Abacn commented on code in PR #23021:
URL: https://github.com/apache/beam/pull/23021#discussion_r966376574
##########
release/src/main/scripts/run_rc_validation.sh:
##########
@@ -55,6 +55,18 @@ function clean_up(){
rm -rf ${LOCAL_BEAM_DIR}
echo "* Deleted workspace ${LOCAL_BEAM_DIR}"
+
+ if [[ -n `which gcloud` ]]; then
+ if [[ -n ${KAFKA_CLUSTER_NAME} ]]; then
+ echo "-----------------------Clean up Kafka Cluster on
GKE------------------------"
Review Comment:
The variable KAFKA_CLUSTER_NAME is created below in L511 solely for the rc
validation. This clean up should only trigger when there is a kafka cluster
being created there. Unless the shell already has an environment variable named
"KAFKA_CLUSTER_NAME" and used for testing, and do not set
`python_xlang_kafka_taxi_dataflow` to true in this test, it is expected not
affecting running test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
