tvalentyn commented on code in PR #23111:
URL: https://github.com/apache/beam/pull/23111#discussion_r966592393
##########
sdks/python/apache_beam/runners/portability/expansion_service_main.py:
##########
@@ -40,13 +41,13 @@ def main(argv):
parser.add_argument(
'-p', '--port', type=int, help='port on which to serve the job api')
parser.add_argument('--fully_qualified_name_glob', default=None)
- parser.add_argument('--default_pickler')
known_args, pipeline_args = parser.parse_known_args(argv)
pipeline_options = PipelineOptions(
pipeline_args + ["--experiments=beam_fn_api",
"--sdk_location=container"])
- if known_args.default_pickler:
- pickler.set_library(known_args.default_pickler)
+ # Set this before any pipeline construction occurs.
+ # See https://github.com/apache/beam/issues/21615
+ pickler.set_library(pipeline_options.view_as(SetupOptions).pickle_library)
Review Comment:
looks like it is called right at the entrypoint of the expansion service
(the process that will be responsible for expanding an external python
transform to incorporate into a Java pipeline).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
