saavan-google-intern commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-650357620
> > The two functions **strip_pcoll_input** and **strip_pcoll_output_** are very similar. Could be refactored into one function. What do you think > > Yeah, they do look similar enough to merge. It's your call. If they do get much longer though they probably should be merged or using a shared method. Okay I refactored it & pushed new tests to cover the gaps I missed earlier ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
