TheNeuralBit commented on issue #23071: URL: https://github.com/apache/beam/issues/23071#issuecomment-1245971834
> Just for clarification, I tested the trigger in Dataflow (both Legacy and UW) and it works as in Java (as it should). Do you mean it worked as in Java on Dataflow, even before your change? > I am not aware how this works in other runners, but I think users would expect it to work as in Java and how it's explained in the documentation. Yes but users sometimes come to rely on buggy behavior :) (obligatory xkcd: https://xkcd.com/1172/) > Do you have any suggestion on how to approach this @TheNeuralBit ? Maybe adding notes in the release? I don't think I have enough context here to advise on a specific action. If this really is just affecting the DirectRunner (non-production) I think it makes sense to just mention this in the release notes. If there's a possibility it will affect production pipelines on Dataflow or other runners we might consider a deprecation cycle (add a warning that behavior will change in a future release, possibly with a new trigger option that preserves existing behavior). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
