TomAugspurger commented on PR #22421: URL: https://github.com/apache/beam/pull/22421#issuecomment-1254915366
> In my last commit, I changed the client.gather command to async mode, and this let me hit a timeout error The ``` self.client.gather(self.futures, errors='raise', asynchronous=True) ``` looks incorrect inside of a regular `def` function. That would typically need to be `await self.client.gather` inside of an async function, since `asynchronous=True` makes that return a coroutine that needs to be awaited. Can you expand on the desire for `asynchronous=True` there? The timeout wasn't working properly without it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
