fernando-wizeline commented on code in PR #23372:
URL: https://github.com/apache/beam/pull/23372#discussion_r980354332


##########
CI.md:
##########
@@ -125,8 +125,26 @@ Service Account shall have following permissions ([IAM 
roles](https://cloud.goog
 | Java Wordcount Direct Runner | Runs Java WordCount example with Direct 
Runner.                                               | Yes              | Yes  
                 | Yes           | -                        |
 | Java Wordcount Dataflow      | Runs Java WordCount example with DataFlow 
Runner.                                             | -                | Yes    
               | Yes           | Yes                      |
 
+### All migrated workflows run based on the following triggers
+
+| Description | Pull Request Run | Direct Push/Merge Run | Scheduled Run | 
Workflow Dispatch |
+|-------------|------------------|-----------------------|---------------|-------------------|
+| PostCommit  | No               | Yes                   | Yes           | Yes 
              |
+| PreCommit   | Yes              | Yes                   | Yes           | No  
              |              

Review Comment:
   Oh, at the moment there is no way to implement trigger phrases on 
postcommits, we decided to emulate the behavior using workflow_dispatch; and, 
since precommits get executed on commits we didn't deem it necessary to include 
workflow_dispatch on them.
   Should we include them also on the precommits? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to