aaltay commented on a change in pull request #12123: URL: https://github.com/apache/beam/pull/12123#discussion_r447282378
########## File path: sdks/python/apache_beam/metrics/metric_test.py ########## @@ -162,7 +161,7 @@ def process(self, element): # Verify user counter. metric_results = ( res.metrics().query( - MetricsFilter().with_name('metrics_user_counter_element'))) + MetricsFilter().with_metric(SomeDoFn.user_counter_elements))) Review comment: Should we add a new test for with_metric instead of replacing the with_name test? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org