Abacn commented on code in PR #22400:
URL: https://github.com/apache/beam/pull/22400#discussion_r983985852
##########
sdks/python/apache_beam/io/mongodbio.py:
##########
@@ -680,6 +680,7 @@ def __init__(
coll=None,
batch_size=100,
extra_client_params=None,
+ writeFn=None,
Review Comment:
Generally in Beam xxxFn implies a DoFn. This is just a callable used in
write. Consider renaming it to 'write_func' or 'write_callback' to avoid
ambiguity and in_line_with_python_nomenclature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
