TheNeuralBit commented on code in PR #23014:
URL: https://github.com/apache/beam/pull/23014#discussion_r984100438
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema.proto:
##########
@@ -139,6 +139,14 @@ message LogicalTypes {
// corresponds to chronological order.
MILLIS_INSTANT = 2 [(org.apache.beam.model.pipeline.v1.beam_urn) =
"beam:logical_type:millis_instant:v1"];
+
+ // A URN for Decimal type
+ // - Representation type: BYTES
+ // - A decimal number with specified scale and value. Its BYTES
Review Comment:
Ohh, I see. It's saying the actual value is the specified precision and a
value. I would probably document it like this:
```suggestion
// - A decimal number with variable scale. Its BYTES
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
