lukecwik commented on code in PR #23165:
URL: https://github.com/apache/beam/pull/23165#discussion_r984979236
##########
sdks/java/container/agent/src/main/java/org/apache/beam/agent/OpenModuleAgent.java:
##########
@@ -24,26 +24,28 @@
import java.util.Map;
import java.util.Set;
+/*
+ * Opens all base modules in the JDK to jamm (used to accurately measure
object sizes)
+ */
public class OpenModuleAgent {
public static void premain(String argument, Instrumentation instrumentation)
{
- Set<Module> automaticModules = new HashSet<>();
Set<Module> modulesToOpen = new HashSet<>();
+ Module jamm = ModuleLayer.boot().findModule("jamm").orElse(null);
Review Comment:
```suggestion
Optional<Module> jamm = ModuleLayer.boot().findModule("jamm");
if (!jamm.isPresent()) {
... log warning about expected to find jamm module ...
return;
}
```
##########
sdks/java/container/agent/src/main/java/org/apache/beam/agent/OpenModuleAgent.java:
##########
@@ -24,26 +24,28 @@
import java.util.Map;
import java.util.Set;
+/*
+ * Opens all base modules in the JDK to jamm (used to accurately measure
object sizes)
+ */
public class OpenModuleAgent {
public static void premain(String argument, Instrumentation instrumentation)
{
- Set<Module> automaticModules = new HashSet<>();
Set<Module> modulesToOpen = new HashSet<>();
+ Module jamm = ModuleLayer.boot().findModule("jamm").orElse(null);
ModuleLayer.boot()
.modules()
.forEach(
module -> {
- if (module.getDescriptor().isAutomatic()) {
- automaticModules.add(module);
- } else if (!module.getDescriptor().isOpen()) {
+ if (!module.getDescriptor().isOpen()) {
modulesToOpen.add(module);
}
});
- if (!automaticModules.isEmpty()) {
+ if (jamm != null) {
+ Set<Module> openModules = Set.of(jamm);
Review Comment:
```suggestion
Set<Module> openModules = Set.of(jamm.get());
```
##########
sdks/java/container/agent/build.gradle:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins {
+ id 'org.apache.beam.module'
+}
+applyJavaNature(
+ exportJavadoc: false,
+ publish: false
+)
+
+description = "Apache Beam :: SDKs :: Java :: Container :: Agent"
+
+jar {
+ manifest {
+ attributes("Agent-Class": "org.apache.beam.agent.OpenModuleAgent",
+ "Can-Redefine-Classes": true,
+ "Can-Retransform-Classes": true,
+ "Premain-Class": "org.apache.beam.agent.OpenModuleAgent")
+ }
+}
+
+if (project.hasProperty('java11Home')) {
+ javaVersion = "1.11"
+ def java11Home = project.findProperty('java11Home')
+ project.tasks.withType(JavaCompile) {
+ options.fork = true
+ options.forkOptions.javaHome = java11Home as File
+ options.compilerArgs += ['-Xlint:-path']
+ }
+} else if (project.hasProperty('java17Home')) {
+ javaVersion = "1.17"
+ def java17Home = project.findProperty("java17Home")
+ project.tasks.withType(JavaCompile) {
Review Comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
