Abacn commented on PR #23548: URL: https://github.com/apache/beam/pull/23548#issuecomment-1273331249
Apologize for a large PR. Most changes are necessary refactors had to do, hopefully they looks trivial and not hard to review - In Java, changed some switch clause to if-else clause that involves Logicaltype.IDENTIFIER defined in proto as they are no longer contant at compile time and cannot use switch. - In Python, refactored option_from/to_runner_api, using their logic to create value_from/to_runner_api as logical type argument values also use them. Also included some fix found that not catched before - AvroUtil logical type did not consider VARBINARY (now VariableBytes) - cythonized RowColumnEncoder cannot handle bytes column becuase nparray([bytes]) element types are np.bytes_ and cython does not recognize it as as bytes - coder_impl.is_compiled flag is always false when cythonized stream module exist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
