eantyshev commented on code in PR #23088:
URL: https://github.com/apache/beam/pull/23088#discussion_r993326484
##########
playground/infrastructure/helper.py:
##########
@@ -112,24 +113,27 @@ def find_examples(work_dir: str, supported_categories:
List[str],
"""
has_error = False
examples = []
- for root, _, files in os.walk(work_dir):
- for filename in files:
- filepath = os.path.join(root, filename)
- error_during_check_file = _check_file(
- examples=examples,
- filename=filename,
- filepath=filepath,
- supported_categories=supported_categories,
- sdk=sdk)
- has_error = has_error or error_during_check_file
+ for subdir in subdirs:
Review Comment:
Let me explain the solution.
If subdirs are sorted alphabetically:
```
01sub/sub
02sub
02sub/subsub
```
it allows to check only pairs of adjacent items, and we don't need to store
items
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
