damccorm commented on code in PR #23112: URL: https://github.com/apache/beam/pull/23112#discussion_r995908636
########## .github/workflows/job-postcommit-java-nexmark-direct.yml: ########## @@ -0,0 +1,201 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Nexmark tests using Direct Runner. + +name: PostCommit Java Nexmark Direct Runner + +on: + workflow_dispatch: + schedule: + - cron: '0 */6 * * *' + push: + branches: ['master', 'release-*'] + tags: 'v*' +permissions: read-all + +env: + BIGQUERYTABLE: nexmark + BIGQUERYDATASET: nexmark + PROJECT: apache-beam-testing + RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE + EXPORTSUMMARYTOBIGQUERY: true + TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark + INFLUXDATABASE: beam_test_metrics + INFLUXHOST: http://10.128.0.96:8086 + BASEINFLUXMEASUREMENT: nexmark + EXPORTSUMMARYTOINFLUXDB: true + INFLUXRETENTIONPOLICY: forever + +jobs: + java-postcommit-nexmark-direct: + name: Run PostCommit Java Nexmark - Direct Runner + runs-on: [self-hosted, ubuntu-20.04] + strategy: + fail-fast: false + timeout-minutes: 240 + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + persist-credentials: false + - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --streaming=false + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN STREAMING MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --streaming=true + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN SQL BATCH MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=sql + --streaming=false + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN SQL STREAM MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=sql + --streaming=true + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN ZETASQL BATCH MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=zetasql + --streaming=false + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: RUN *** NEXMARK IN ZETASQL STREAMING MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=sql + --streaming=true + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " Review Comment: Is the only difference here the streaming variable and the queryLanguage? If so, can we just make these separate jobs and use a matrix to run with each variable type? ########## .github/workflows/job-postcommit-java-nexmark-direct.yml: ########## @@ -0,0 +1,201 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Nexmark tests using Direct Runner. + +name: PostCommit Java Nexmark Direct Runner + +on: + workflow_dispatch: + schedule: + - cron: '0 */6 * * *' + push: + branches: ['master', 'release-*'] + tags: 'v*' +permissions: read-all + +env: + BIGQUERYTABLE: nexmark + BIGQUERYDATASET: nexmark + PROJECT: apache-beam-testing + RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE + EXPORTSUMMARYTOBIGQUERY: true + TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark + INFLUXDATABASE: beam_test_metrics + INFLUXHOST: http://10.128.0.96:8086 + BASEINFLUXMEASUREMENT: nexmark + EXPORTSUMMARYTOINFLUXDB: true + INFLUXRETENTIONPOLICY: forever + +jobs: + java-postcommit-nexmark-direct: + name: Run PostCommit Java Nexmark - Direct Runner + runs-on: [self-hosted, ubuntu-20.04] + strategy: + fail-fast: false + timeout-minutes: 240 + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + persist-credentials: false + - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER *** Review Comment: Same comment applies elsewhere - please remove bold/all caps ########## .github/workflows/job-postcommit-java-nexmark-direct.yml: ########## @@ -0,0 +1,201 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Nexmark tests using Direct Runner. + +name: PostCommit Java Nexmark Direct Runner + +on: + workflow_dispatch: + schedule: + - cron: '0 */6 * * *' + push: + branches: ['master', 'release-*'] + tags: 'v*' +permissions: read-all + +env: + BIGQUERYTABLE: nexmark Review Comment: These environment variables are used in a number of workflows. Should we refactor them to our shared variable config? ########## .github/workflows/job-postcommit-java-nexmark-direct.yml: ########## @@ -0,0 +1,201 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Nexmark tests using Direct Runner. + +name: PostCommit Java Nexmark Direct Runner + +on: + workflow_dispatch: + schedule: + - cron: '0 */6 * * *' + push: + branches: ['master', 'release-*'] + tags: 'v*' +permissions: read-all + +env: + BIGQUERYTABLE: nexmark + BIGQUERYDATASET: nexmark + PROJECT: apache-beam-testing + RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE + EXPORTSUMMARYTOBIGQUERY: true + TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark + INFLUXDATABASE: beam_test_metrics + INFLUXHOST: http://10.128.0.96:8086 + BASEINFLUXMEASUREMENT: nexmark + EXPORTSUMMARYTOINFLUXDB: true + INFLUXRETENTIONPOLICY: forever + +jobs: + java-postcommit-nexmark-direct: + name: Run PostCommit Java Nexmark - Direct Runner + runs-on: [self-hosted, ubuntu-20.04] + strategy: + fail-fast: false + timeout-minutes: 240 + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + persist-credentials: false + - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --streaming=false + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN STREAMING MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --streaming=true + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN SQL BATCH MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=sql + --streaming=false + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN SQL STREAM MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=sql + --streaming=true + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: Run *** RUN NEXMARK IN ZETASQL BATCH MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=zetasql + --streaming=false + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " + - name: RUN *** NEXMARK IN ZETASQL STREAMING MODE USING DIRECT RUNNER *** + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: > + :sdks:java:testing:nexmark:run -Pnexmark.runner=:runners:direct-java + -Pnexmark.args=" + --runner=DirectRunner + --bigQueryTable=$BIGQUERYTABLE + --bigQueryDataset=$BIGQUERYDATASET + --project=$PROJECT + --resourceNameMode=$RESOURCENAMEMODE + --exportSummaryToBigQuery=$EXPORTSUMMARYTOBIGQUERY + --tempLocation=$TEMPLOCATION + --influxDatabase=$INFLUXDATABASE + --influxHost=$INFLUXHOST + --baseInfluxMeasurement=$BASEINFLUXMEASUREMENT + --exportSummaryToInfluxDB=$EXPORTSUMMARYTOINFLUXDB + --influxRetentionPolicy=$INFLUXRETENTIONPOLICY + --queryLanguage=sql + --streaming=true + --suite=SMOKE + --manageResources=false + --monitorJobs=true + --enforceEncodability=true + --enforceImmutability=true " Review Comment: Same comment applies below in the other workflows. In fact, if the runner is the only difference, we could probably just consolidate to a single workflow and use matrix builds on the runner. ########## .github/workflows/job-postcommit-java-nexmark-direct.yml: ########## @@ -0,0 +1,201 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Nexmark tests using Direct Runner. + +name: PostCommit Java Nexmark Direct Runner + +on: + workflow_dispatch: + schedule: + - cron: '0 */6 * * *' + push: + branches: ['master', 'release-*'] + tags: 'v*' +permissions: read-all + +env: + BIGQUERYTABLE: nexmark + BIGQUERYDATASET: nexmark + PROJECT: apache-beam-testing + RESOURCENAMEMODE: QUERY_RUNNER_AND_MODE + EXPORTSUMMARYTOBIGQUERY: true + TEMPLOCATION: gs://temp-storage-for-perf-tests/nexmark + INFLUXDATABASE: beam_test_metrics + INFLUXHOST: http://10.128.0.96:8086 + BASEINFLUXMEASUREMENT: nexmark + EXPORTSUMMARYTOINFLUXDB: true + INFLUXRETENTIONPOLICY: forever + +jobs: + java-postcommit-nexmark-direct: + name: Run PostCommit Java Nexmark - Direct Runner + runs-on: [self-hosted, ubuntu-20.04] + strategy: + fail-fast: false + timeout-minutes: 240 + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + persist-credentials: false + - name: Run *** RUN NEXMARK IN BATCH MODE USING DIRECT RUNNER *** Review Comment: ```suggestion - name: Run Nexmark in Batch mode on the direct runner ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
