andoni-guzman commented on code in PR #23102: URL: https://github.com/apache/beam/pull/23102#discussion_r995942340
########## .github/workflows/job-postcommit-java-jpms-flink.yml: ########## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Tests for PostCommit JPMS using Flink runner with Java 11 + +name: PostCommit Java JPMS Flink Java 11 + +on: + workflow_dispatch: + schedule: + - cron: '0 */6 * * *' + push: + branches: ['master', 'release-*'] + tags: 'v*' + +jobs: + java-postcommit-jpms-java11: + name: Run PostCommit Java JPMS Flink - Java 11 + runs-on: [self-hosted, ubuntu-20.04] + timeout-minutes: 240 + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + persist-credentials: false + - uses: actions/checkout@v3 + - name: Set up JDK 11 Review Comment: HI Danny, No in this cases ( flink and spark) the original groovy test only contemplate Java 11 ########## .github/workflows/job-postcommit-java-jpms-spark.yml: ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Tests for PostCommit JPMS using Spark runner with Java 11 + + +name: PostCommit Java JPMS Spark Java 11 + +on: + workflow_dispatch: + schedule: + - cron: '0 */6 * * *' + push: + branches: ['master', 'release-*'] + tags: 'v*' + +jobs: + java-postcommit-jpms-spark: + name: Run PostCommit Java JPMS Spark - Java 11 + runs-on: [self-hosted, ubuntu-20.04] + timeout-minutes: 240 + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + persist-credentials: false + - uses: actions/checkout@v3 + - name: Set up JDK 11 + uses: actions/setup-java@v3 + with: + java-version: '11' Review Comment: HI Danny, No in this cases ( flink and spark) the original groovy test only contemplate Java 11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
