andoni-guzman commented on code in PR #23187:
URL: https://github.com/apache/beam/pull/23187#discussion_r995956554
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2611,7 +2611,7 @@ class BeamModulePlugin implements Plugin<Project> {
def distTarBall = "${pythonRootDir}/build/apache-beam.tar.gz"
project.exec {
executable 'sh'
- args '-c', ". ${project.ext.envdir}/bin/activate && cd
${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
+ args '-c', ". ${project.ext.envdir}/bin/activate && cd
${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall $posargs"
Review Comment:
There was a parsing error caused by this quotes, in the case that the string
contains multiple quotes and double quotes, the solution was deleted this
quotes. For example in python examples we had
`"'apache_beam/examples/complete/game/ \
apache_beam/examples/complete/autocomplete_test.py \
apache_beam/examples/complete/distribopt_test.py \`
Gradlew failed to parse this string , failing the execution.
The reason to execute all the test in one gradle job is to save time and
resources. Also I tried using regular expressions but doesn't work , gradle
parse it literally.
Put in a matrix all the jobs generate a lot of executions only for one small
test.
I tested this change with other workflows and everything was well. But I
worried if this change could affect another code or tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
