tvalentyn commented on code in PR #23668:
URL: https://github.com/apache/beam/pull/23668#discussion_r997466260
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -133,6 +133,14 @@ def error(self, message):
super().error(message)
+class _DictUnionAction(argparse.Action):
+ def __call__(self, parser, namespace, values, option_string=None):
+ if hasattr(namespace,
+ self.dest) and getattr(namespace, self.dest) is not None:
+ values.update(getattr(namespace, self.dest))
Review Comment:
when a flag is specified multiple times, usually the last occurrence takes
precedence. I think we should initialize or update self.dest with new values ,
not the opposite. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
