je-ik commented on a change in pull request #12152:
URL: https://github.com/apache/beam/pull/12152#discussion_r448511263
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java
##########
@@ -1110,17 +1109,7 @@ public void updateWatermarks(
pendingUpdates.offer(
PendingWatermarkUpdate.create(
executable, completed, timerUpdate, unprocessedInputs, outputs,
earliestHold));
- tryApplyPendingUpdates();
- }
-
- private void tryApplyPendingUpdates() {
- if (refreshLock.tryLock()) {
- try {
- applyNUpdates(MAX_INCREMENTAL_UPDATES);
- } finally {
- refreshLock.unlock();
- }
- }
Review comment:
Not sure what was the purpose for limiting the number of applied
updates, but that seems to be wrong - we need to apply all updates at all
times, because otherwise we again might not hold the downstream watermark back
enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
