alexeyinkin commented on code in PR #23662:
URL: https://github.com/apache/beam/pull/23662#discussion_r997952019
##########
playground/frontend/playground_components/lib/src/theme/theme.dart:
##########
@@ -363,5 +380,34 @@ RoundedRectangleBorder _getButtonBorder(double radius) {
);
}
+MarkdownStyleSheet _getMarkdownStyle(Brightness brightness) {
+ final primaryColor = brightness == Brightness.light
Review Comment:
A single if is better structured than three ternaries:
```dart
final Color primaryColor;
final Color codeblockBackgroundColor;
final Color textColor;
if (brightness == Brightness.light) {
// init
} else {
// init
}
```
##########
playground/frontend/playground_components/lib/src/theme/theme.dart:
##########
@@ -32,16 +33,21 @@ class BeamThemeExtension extends
ThemeExtension<BeamThemeExtension> {
final Color lightGreyBackgroundTextColor;
final Color secondaryBackgroundColor;
+ final Color codeBackgroundColor;
final TextStyle codeRootStyle;
final CodeThemeData codeTheme;
+ final MarkdownStyleSheet? markdownStyle;
Review Comment:
Any reasons to make it nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
