scwhittle commented on code in PR #23333:
URL: https://github.com/apache/beam/pull/23333#discussion_r998369224
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -941,14 +958,18 @@ public void addWorkerStatusPage(BaseStatusServlet page) {
public void stop() {
try {
if (globalConfigRefreshTimer != null) {
- globalConfigRefreshTimer.cancel();
+ globalConfigRefreshTimer.shutdown();
+ globalConfigRefreshTimer.awaitTermination(300, TimeUnit.SECONDS);
Review Comment:
It's really only in tests, so I think if it was a concern we would have
timeouts already.
I'd be hesitant to change it just in case it makes something flaky if it
isn't currently a problem.
Could leave a comment about that being possible to speed up shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
