andoni-guzman commented on PR #23110: URL: https://github.com/apache/beam/pull/23110#issuecomment-1282707959
Hi @damccorm . I did some changes. I test all the changes to verify that the test were not broken. - I modify the names of the test like you suggest, like "Run Nexmark with Batch on Dataflow" - In test-properties.json added all the variables that were repeated in the tests. - In job-postcommit-java-nexmark-dataflow, use a matrix for all the tipes of executions of the job, only 1 job is in code, but in the workflow 6 jobs are executed - In job-postcommit-java-nexmark-dataflowV2, some variables that were used in all the tests are getting from test-properties.json, the variables for Java 8, Java 11 and Java 17 still are in env variables because json parsing erros in other way. Any other change please let me know -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
