reuvenlax commented on code in PR #23615:
URL: https://github.com/apache/beam/pull/23615#discussion_r1002545053


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -2056,7 +2059,9 @@ public enum Method {
 
     abstract Boolean getPropagateSuccessful();
 
-    abstract Boolean getAutoSchemaUpdate();
+    abstract Boolean getAutoSchemaRefresh();
+
+    abstract Duration getSchemaRefreshFrequency();

Review Comment:
   So we had a previously-implemented "schema update" feature that was strongly 
consistent, i.e. any time a record showed up with unknown values, it triggered 
a check of the BQ table. This feature didn't work for users that frequently had 
such records (those users had records that always had unknown fields in every 
record). 
   
   If we removed the old feature, then we could rely on one property. If we 
keep both, then we need a way to distinguish.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to