arne-alex commented on code in PR #23333:
URL: https://github.com/apache/beam/pull/23333#discussion_r1004979110
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -2382,6 +2458,7 @@ public List<Windmill.KeyedGetDataRequest>
getKeysToRefresh(Instant refreshDeadli
.setKey(shardedKey.key())
.setShardingKey(shardedKey.shardingKey())
.setWorkToken(work.getWorkItem().getWorkToken())
+
.addAllLatencyAttribution(work.getLatencyAttributionList())
Review Comment:
StreamingDataflowWorker refreshes active work items every few seconds by
sending empty KeyedGetDataRequests. We want to detect work items that are stuck
on user processing, so we need regular updates WHILE processing. Sending ONLY
an update on the commit isn't enough, but we've filed it as future work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
