aromanenko-dev commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r449044147
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/MetricsAccumulator.java
##########
@@ -58,13 +57,13 @@ public static void init(SparkPipelineOptions opts,
JavaSparkContext jsc) {
opts.isStreaming()
? Optional.of(new CheckpointDir(opts.getCheckpointDir()))
: Optional.absent();
- MetricsContainerStepMap metricsContainerStepMap = new
MetricsContainerStepMap();
+ SparkMetricsContainerStepMap metricsContainerStepMap = new
SparkMetricsContainerStepMap();
Review comment:
Won't it be enough to just create new instance of
`SparkMetricsContainerStepMap` here but keep the same interface of
`MetricsContainerStepMap` everywhere as it was before get broken? Why do we
need to change it everywhere since `SparkMetricsContainerStepMap ` just
overrides `toString()`?
Also, it would be great to add a test for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
