agvdndor commented on code in PR #23094: URL: https://github.com/apache/beam/pull/23094#discussion_r1006464993
########## sdks/python/apache_beam/examples/ml-orchestration/kfp/components/ingestion/component.yaml: ########## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Ingestion +description: Component that mimicks scraping data from the web and outputs it to a jsonlines format file +inputs: + - name: base_artifact_path + description: base path to store data + type: String +outputs: + - name: ingested_dataset_path + description: target uri for the ingested dataset + type: String +implementation: + container: + image: <your-docker-registry/ingestion-image-name:latest> Review Comment: That would be an option as well indeed. I'm just a bit worried that it again adds a little more complexity to the docs themselves, of course in favor of having an example that is easier to run. If that's fine, we can add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
