alexeyinkin commented on code in PR #24031:
URL: https://github.com/apache/beam/pull/24031#discussion_r1016807387
##########
playground/frontend/lib/modules/examples/components/example_list/example_item_actions.dart:
##########
@@ -36,8 +36,8 @@ class ExampleItemActions extends StatelessWidget {
return Row(
children: [
if (example.isMultiFile) multifilePopover,
- if (example.complexity != Complexity.unspecified)
- ComplexityWidget(complexity: example.complexity),
+ if (example.complexity != null)
Review Comment:
`null` is always better than a null-constant in an enum. Advantages include:
- Less identifiers.
- More distinction from other values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
