lostluck commented on code in PR #16658:
URL: https://github.com/apache/beam/pull/16658#discussion_r1017169559
##########
sdks/python/container/boot.go:
##########
@@ -73,13 +74,20 @@ const (
)
func main() {
+ if err := mainError(); err != nil {
+ log.Print(err)
+ os.Exit(1)
Review Comment:
In this case the logic isn't implicit for log.Fatal and log.Fatalf. It's
both the documented and implemented behavior. It's a signal to the reader that
this is an expected errorful exit.
Go as a rule is fairly explicit, but it also needs to be balanced with
avoiding verbose repetition. Hence functions to improve readability. This
allows readers to note that something interesting is going on, vs the split
call, when they see an explicit Print followed by an exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
