damccorm commented on code in PR #24023:
URL: https://github.com/apache/beam/pull/24023#discussion_r1018387410
##########
.github/workflows/typescript_tests.yml:
##########
@@ -103,3 +103,70 @@ jobs:
working-directory: ./sdks/typescript
env:
BEAM_SERVICE_OVERRIDES: '{"python:*": "python"}'
+
+ check_gcp_variables:
+ timeout-minutes: 5
+ name: "Check GCP variables"
+ runs-on: ubuntu-latest
+ outputs:
+ gcp-variables-set: ${{
steps.check_gcp_variables.outputs.gcp-variables-set }}
+ steps:
+ - uses: actions/checkout@v3
+ - name: "Check are GCP variables set"
+ run: "./scripts/ci/ci_check_are_gcp_variables_set.sh"
+ id: check_gcp_variables
+ env:
+ GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }}
Review Comment:
This won't work on prs because secrets aren't available to forks by default.
Note that in the Python version this is gated on the secrets being available in
https://github.com/apache/beam/blob/b5a0f4895ccf7bd2f8b03217d866e8d0c67f6f52/.github/workflows/build_wheels.yml#L175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
