NianticRyan commented on issue #24098: URL: https://github.com/apache/beam/issues/24098#issuecomment-1312036178
I'm not convinced that will solve the issue. That github post is complaining about non-deterministic behavior between scan() and scan(1). Rolling back the workaround removes the scan entirely. I can't say exactly why the full scan is needed, but I can theorize that in the original commit [#16275](https://github.com/apache/beam/pull/16275) the committer meant to say that the full scan is needed, but they could not use scan() and rather needed to use scan(1) due to the bug in classgraph. scan() still runs a full scan of the classpath and objects. It just does it with multiple threads rather than scan(1) which only does it with 1 thread. If we change to using that, then we still have a bug because we need to close the ScanReport which comes back from the scan() call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
