amaliujia commented on a change in pull request #12169:
URL: https://github.com/apache/beam/pull/12169#discussion_r450529634
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ConversionContext.java
##########
@@ -33,7 +33,16 @@
private final ExpressionConverter expressionConverter;
private final RelOptCluster cluster;
private final QueryTrait trait;
- private final Map<List<String>, ResolvedNode> sqlUDTVF;
+ // Pure-sql user-defined table-valued function can be resolved by Analyzer.
Keeping the
Review comment:
The comments here are all about "pure-sql" UDF (it won't apply to
java/python UDF). Is there a better naming in your mind (or you are prefer to
add a link some where to explain what is "pure-sql" UDF?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
