damccorm commented on code in PR #24175:
URL: https://github.com/apache/beam/pull/24175#discussion_r1023169531
##########
.github/workflows/go_tests.yml:
##########
@@ -44,7 +44,7 @@ jobs:
fetch-depth: 2
- uses: actions/setup-go@v3
with:
- go-version: '1.18'
+ go-version: '1.19'
Review Comment:
+1 - we should also probably matrix from the
GoTestProperties.SUPPORTED_VERSIONS variable like we do here -
https://github.com/apache/beam/blob/067763e1e7458a49d274860c02b99004bf22d0e9/.github/workflows/job-precommit-python.yml#L85
That way there's a single place to update going forwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
